Skip to content

Rewrite emphasis and strong processing to be more GFM compliant #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Crozzers wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Rewrite emphasis and strong processing to be more GFM compliant #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bf0a1e2
Re-write the IAB processor to implement GFM rules
Crozzers Nov 30, 2025
6ade9ab
Get closer to GFM compliance
Crozzers Nov 30, 2025
b3e512d
Iron out some GFM edge cases
Crozzers Dec 5, 2025
366ad8c
Acheive near full GFM compliance on iab
Crozzers Dec 5, 2025
e8e7ced
Acheive near complete GFM compliance
Crozzers Dec 7, 2025
5988b09
Refactor inheritants of original IABP to use new GFM variant.
Crozzers Dec 7, 2025
060d48d
Add issues 645, 652, 653 and 654 to gfm test case
Crozzers Dec 7, 2025
3b19616
Improve performance in repetitive (ReDoS) scenarios by caching some I…
Crozzers Dec 7, 2025
749c9cb
Fix python typing syntax error
Crozzers Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
501 changes: 451 additions & 50 deletions lib/markdown2.py
View file
Open in desktop

Large diffs are not rendered by default.

269 changes: 269 additions & 0 deletions test/tm-cases/gfm_emphasis.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,269 @@
<p><em>foo bar</em></p>

<p>a * foo bar*</p>

<p>a*"foo"*</p>

<ul>
<li>a *</li>
</ul>

<p>foo<em>bar</em></p>

<p>5<em>6</em>78</p>

<p>пристаням<em>стремятся</em></p>

<p>aa_"bb"_cc</p>

<p>foo-<em>(bar)</em></p>

<p>_foo*</p>

<p>*foo bar *</p>

<p>*foo bar
*</p>

<p>*(*foo)</p>

<p><em>(<em>foo</em>)</em></p>

<p><em>foo</em>bar</p>

<p>_foo bar _</p>

<p>_(_foo)</p>

<p><em>(<em>foo</em>)</em></p>

<p><em>foo</em>bar</p>

<p><em>пристаням</em>стремятся</p>

<p><em>foo</em>bar<em>baz</em></p>

<p><em>(bar)</em>.</p>

<p><strong>foo bar</strong></p>

<p>** foo bar**</p>

<p>a**"foo"**</p>

<p>foo<strong>bar</strong></p>

<p><strong>foo bar</strong></p>

<p>__ foo bar__</p>

<p>__
foo bar__</p>

<p>a__"foo"__</p>

<p>foo<strong>bar</strong></p>

<p>5<strong>6</strong>78</p>

<p>пристаням<strong>стремятся</strong></p>

<p><strong>foo, <strong>bar</strong>, baz</strong></p>

<p>foo-<strong>(bar)</strong></p>

<p>**foo bar **</p>

<p>**(**foo)</p>

<p><em>(<strong>foo</strong>)</em></p>

<p><strong>Gomphocarpus (<em>Gomphocarpus physocarpus</em>, syn.
<em>Asclepias physocarpa</em>)</strong></p>

<p><strong>foo "<em>bar</em>" foo</strong></p>

<p><strong>foo</strong>bar</p>

<p>__foo bar __</p>

<p>__(__foo)</p>

<p><em>(<strong>foo</strong>)</em></p>

<p><strong>foo</strong>bar</p>

<p><strong>пристаням</strong>стремятся</p>

<p><strong>foo</strong>bar<strong>baz</strong></p>

<p><strong>(bar)</strong>.</p>

<p><em>foo <a href="/url">bar</a></em></p>

<p><em>foo
bar</em></p>

<p><em>foo <strong>bar</strong> baz</em></p>

<p><em>foo <em>bar</em> baz</em></p>

<p><em><em>foo</em> bar</em></p>

<p><em>foo <em>bar</em></em></p>

<p><em>foo <strong>bar</strong> baz</em></p>

<p><em>foo<strong>bar</strong>baz</em></p>

<p><em>foo</em><em>bar</em></p>

<p><em><strong>foo</strong> bar</em></p>

<p><em>foo <strong>bar</strong></em></p>

<p><em>foo<strong>bar</strong></em></p>

<p>foo<em><strong>bar</strong></em>baz</p>

<p>foo<strong><strong><strong>bar</strong></strong></strong>***baz</p>

<p><em>foo <strong>bar <em>baz</em> bim</strong> bop</em></p>

<p><em>foo <a href="/url"><em>bar</em></a></em></p>

<p>** is not an empty emphasis</p>

<p>**** is not an empty strong emphasis</p>

<p><strong>foo <a href="/url">bar</a></strong></p>

<p><strong>foo
bar</strong></p>

<p><strong>foo <em>bar</em> baz</strong></p>

<p><strong>foo <strong>bar</strong> baz</strong></p>

<p><strong><strong>foo</strong> bar</strong></p>

<p><strong>foo <strong>bar</strong></strong></p>

<p><strong>foo <em>bar</em> baz</strong></p>

<p><strong>foo<em>bar</em>baz</strong></p>

<p><strong><em>foo</em> bar</strong></p>

<p><strong>foo <em>bar</em></strong></p>

<p><strong>foo <em>bar <strong>baz</strong>
bim</em> bop</strong></p>

<p><strong>foo <a href="/url"><em>bar</em></a></strong></p>

<p>__ is not an empty emphasis</p>

<p>____ is not an empty strong emphasis</p>

<p>foo ***</p>

<p>foo <em>*</em></p>

<p>foo <em>_</em></p>

<p>foo *****</p>

<p>foo <strong>*</strong></p>

<p>foo <strong>_</strong></p>

<p>*<em>foo</em></p>

<p><em>foo</em>*</p>

<p>*<strong>foo</strong></p>

<p>***<em>foo</em></p>

<p><strong>foo</strong>*</p>

<p><em>foo</em>***</p>

<p>foo ___</p>

<p>foo <em>_</em></p>

<p>foo <em>*</em></p>

<p>foo _____</p>

<p>foo <strong>_</strong></p>

<p>foo <strong>*</strong></p>

<p>_<em>foo</em></p>

<p><em>foo</em>_</p>

<p>_<strong>foo</strong></p>

<p>___<em>foo</em></p>

<p><strong>foo</strong>_</p>

<p><em>foo</em>___</p>

<p><strong>foo</strong></p>

<p><em><em>foo</em></em></p>

<p><strong>foo</strong></p>

<p><em><em>foo</em></em></p>

<p><strong><strong>foo</strong></strong></p>

<p><strong><strong>foo</strong></strong></p>

<p><strong><strong><strong>foo</strong></strong></strong></p>

<p><em><strong>foo</strong></em></p>

<p><em><strong><strong>foo</strong></strong></em></p>

<p><em>foo _bar</em> baz_</p>

<p><em>foo <strong>bar *baz bim</strong> bam</em></p>

<p>**foo <strong>bar baz</strong></p>

<p>*foo <em>bar baz</em></p>

<p>*<a href="/url">bar*</a></p>

<p>_foo <a href="/url">bar_</a></p>

<p>*<img src="foo" title="*"/></p>

<p>**<a href="**"></p>

<p>__<a href="__"></p>

<p><em>a <code>*</code></em></p>

<p><em>a <code>_</code></em></p>

<p>**a<a href="http://foo.bar/?q=**">http://foo.bar/?q=**</a></p>

<p>__a<a href="http://foo.bar/?q=__">http://foo.bar/?q=__</a></p>

<p><strong>foo*bar</strong></p>

<p>_foo <strong>bar</strong> baz._bim</p>

<p><strong>__foo</strong> bar <strong>__baz</strong> bim <em>bam</em></p>

<p><strong>foo<em>bar</em></strong></p>

<p><strong><em>foo</em>bar</strong></p>
Loading