Improve accuracy of escape sequences in string and character literals #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few cases where the current escape sequence parser is inaccurate, which causes misleading syntax highlighting. * `hexadecimal-escape-sequence` does not have a maximum length, so `'\x00000000a'` is the same as `'\n'`. Godbolt link: https://godbolt.org/z/fq18PbPc4 * `octal-escape-sequence` can only contain octal digits `[0-7]`, so `"\749"` is `"<9"` and the `9` should not be highlighted as part of the escape sequence. Godbolt link: https://godbolt.org/z/rEcM88had * Any other character except the valid escape sequence characters are not allowed in escape sequences, so they should not be highlighted as escape sequences. This PR introduces `invalid_escape_sequence` so that invalid escape sequences can be highlighted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few cases where the current escape sequence parser is inaccurate, which causes misleading syntax highlighting.
hexadecimal-escape-sequencedoes not have a maximum length, so'\x00000000a'is the same as'\n'. Godbolt link: https://godbolt.org/z/fq18PbPc4octal-escape-sequencecan only contain octal digits[0-7], so"\749"is"<9"and the9should not be highlighted as part of the escape sequence. Godbolt link: https://godbolt.org/z/rEcM88hadinvalid_escape_sequenceso that invalid escape sequences can be highlighted.