Skip to content

Commit

Permalink
Merge pull request #225 from transifex/missing-policy-params
Browse files Browse the repository at this point in the history
TXNative: Expose params in missing policies
  • Loading branch information
Nikos Vasileiou authored Jul 3, 2024
2 parents 3130255 + b36501c commit 11b774f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/native/src/TxNative.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export default class TxNative {
}

if (isMissing && locale) {
translation = this.missingPolicy.handle(translation, locale);
translation = this.missingPolicy.handle(translation, locale, params);
}

if (!isString(translation)) translation = `${translation}`;
Expand Down
6 changes: 3 additions & 3 deletions packages/native/src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ declare module '@transifex/native' {
}

interface ITranslationPolicy {
handle(sourceString: string, localeCode: string): string;
handle(sourceString: string, localeCode: string, params: ITranslateParams): string;
}

interface IErrorPolicy {
Expand Down Expand Up @@ -124,15 +124,15 @@ declare module '@transifex/native' {
}

export class PseudoTranslationPolicy implements ITranslationPolicy {
handle(sourceString: string, _localeCode: string): string;
handle(sourceString: string, _localeCode: string, _params: ITranslateParams): string;
}

export class SourceErrorPolicy implements IErrorPolicy {
handle(_error: Error, sourceString: string, _localeCode: string, _params: ITranslateParams): string;
}

export class SourceStringPolicy implements ITranslationPolicy {
handle(sourceString: string, _localeCode: string): string;
handle(sourceString: string, _localeCode: string, _params: ITranslateParams): string;
}

export class ThrowErrorPolicy implements IErrorPolicy {
Expand Down
2 changes: 1 addition & 1 deletion packages/native/src/policies/PseudoTranslationPolicy.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const MAP = {
* @class PseudoTranslationPolicy
*/
export default class PseudoTranslationPolicy {
handle(sourceString, localeCode) {
handle(sourceString, localeCode, params) {
return sourceString
.split(/__txnative__/)
.map((group) => {
Expand Down
2 changes: 1 addition & 1 deletion packages/native/src/policies/SourceStringPolicy.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @class SourceStringPolicy
*/
export default class SourceStringPolicy {
handle(sourceString, localeCode) {
handle(sourceString, localeCode, params) {
return sourceString;
}
}

0 comments on commit 11b774f

Please sign in to comment.