autofixes from prettier and eslint --write
#425
Conversation
bencmbrook
changed the title
prettier and eslint --write
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| export function extractClientError(err: string): string | null { | ||
| return CLIENT_ERROR.test(err) ? CLIENT_ERROR.exec(err)![1] : null; | ||
| export function extractClientError(error: string): string | null { | ||
| return CLIENT_ERROR.test(error) ? CLIENT_ERROR.exec(error)![1] : null; |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| export function extractClientError(err: string): string | null { | ||
| return CLIENT_ERROR.test(err) ? CLIENT_ERROR.exec(err)![1] : null; | ||
| export function extractClientError(error: string): string | null { | ||
| return CLIENT_ERROR.test(error) ? CLIENT_ERROR.exec(error)![1] : null; |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| [key.replace(/[^a-z_.+\-A-Z -~]/g, '')]: value, | ||
| (accumulator, [key, value]) => | ||
| Object.assign(accumulator, { | ||
| [key.replaceAll(/[^a-z_.+\-A-Z -~]/g, '')]: value, |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the issue, we need to rewrite the regular expression to avoid overlapping ranges while maintaining its intended functionality. The range -~ should be replaced with a more explicit and non-overlapping set of characters. Since the regex appears to target printable ASCII characters, we can explicitly list the allowed characters without relying on overlapping ranges. This will make the regex clearer and easier to maintain.
The updated regex will explicitly include:
- Lowercase letters (
a-z) - Uppercase letters (
A-Z) - Digits (
0-9) - Specific symbols (
_.+-and space)
The corrected regex will be /[^a-zA-Z0-9_.+\- ]/g.
| @@ -30,3 +30,3 @@ | ||
| Object.assign(accumulator, { | ||
| [key.replaceAll(/[^a-z_.+\-A-Z -~]/g, '')]: value, | ||
| [key.replaceAll(/[^a-zA-Z0-9_.+\- ]/g, '')]: value, | ||
| }), |
bencmbrook
changed the base branch from
main
to
bencmbrook/upgrade-pretter-eslint-node
PR stack:
main
<--#427 (eslint and prettier config changes)<--#425 (auto-formatting from config changes)<--#426 (manual fixes which actually are code changes)Related Issues
Security Implications
[none]
System Availability
[none]