Skip to content

[WIP] Add silo discovery recommendations to tr-pull #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

blevine-transcend
Copy link
Contributor

@blevine-transcend blevine-transcend commented Jan 18, 2025

Add ability to pull silo discovery recommendations from tr-pull. does not support push.

came up from convo with IP when working with CTCT's silo list.

@blevine-transcend blevine-transcend changed the title Add discovery recommendations cli pull [WIP] Add discovery recommendations cli pull Jan 18, 2025
@blevine-transcend blevine-transcend changed the title [WIP] Add discovery recommendations cli pull [WIP] Add silo discovery recommendations to tr-pull Jan 18, 2025
Copy link
Member

@michaelfarrell76 michaelfarrell76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow beautiful stuff!!! im so sorry about the delay on this totally slipped my mind and got lost in some other notifications

you can also tag @MadDataScience @anotherminh @abrantesarthur for reviews on this repo they've contributed quite a bit as well

@michaelfarrell76
Copy link
Member

a few last things

  1. since this is a bit out of date with main - id make sure to merge the main branch into your branch. git checkout main; git pull; git checkout add-discovery-recommendations-cli-pull; git merge main;
  2. make sure to update the package.json version - bump the minor value (the middle number). once the PR is merged it will auto deploy to npm registry. if you forget to bump the package.json version it won't publish
  3. Run yarn script:transcend-json-schema to fix the generate-json-schema job - this pushes an updated configuration for the transcend.yml up to a registry that allows for editors like vscode to type-check the yaml format
  4. run pre-commit install to install pre-commits locally on your machine. going format this will run before you push a commit and it will run some auto-fixes to fix the pre-commit ci errors. since these didn't run when you made the commit - you can run pre-commit run -a to run them all. that will change a few files that you will want to commit and push up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants