Skip to content

Expose (IPendingEvent | IPendingCookieMutation).block API #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

eligrey
Copy link
Member

@eligrey eligrey commented Apr 11, 2025

This API is being added in airgap.js 9.60.0

Related Issues

Security Implications

[none]

System Availability

[none]

@eligrey eligrey requested a review from a team April 11, 2025 03:16
Copy link

height bot commented Apr 11, 2025

This pull request has been linked to and will mark 1 task as "Pending Deploy" when merged:

💡Tip: You can link multiple Height tasks to a pull request.

@eligrey eligrey requested a review from Copilot April 11, 2025 06:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@eligrey eligrey requested a review from csmccarthy April 21, 2025 18:52
csmccarthy
csmccarthy previously approved these changes Apr 21, 2025
Copy link
Member

@csmccarthy csmccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add a new section to the override docs for this if you havent already!

@eligrey
Copy link
Member Author

eligrey commented Apr 23, 2025

documented in https://github.com/transcend-io/docs/pull/2003/files -- we don't expose some PendingEvent API details intentionally so there isn't a detailed break-down with examples yet. the API types are documented in a section near the bottom of the API docs page

@eligrey eligrey merged commit 785d296 into main Apr 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants