Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added button to hide DLC #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Logical-sh
Copy link

This adds a button to hide DLC.
This is a feature found in SteamEdit, and needed to play some games on linux (Assassin's creed II is an example. You need to hide the MAC key or it refuses to launch.)

This adds a button to hide DLC. 
This is a feature found in SteamEdit, and needed to play some games on linux (Assassin's creed II is an example. You need to hide the MAC key or it refuses to launch.)
@tralph3
Copy link
Owner

tralph3 commented Mar 11, 2021

Nice one, I didn't notice this had other purposes than just hiding it from view. Just some notes, you don't need to cal update_launch_menu_window(), that function exists to... update the launch menu window (the one that lets you edit the launch menu for each game, so you can launch a different executable). It's called when you move options up/down or remove them, it basically creates the launch menu window from the info found on the dictionary. There's no need to call it, in fact, it's raising exceptions due to it.

Also, I would rather have the button always there, and enable/disable it depending on if the app is a dlc or not (I do something similar with the launch menu thing, I only enable it for things that make sense, a DLC ain't one of those things so it's greyed out. It's also disabled for uninstalled apps). Since you're at it, you can also check if the app is already hidden or not, and change the label accordingly. I'd much rather have this than packing/removing widgets on the fly, which can be messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants