Skip to content

fix: custom metrics for the default metrics #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mk-brett wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: custom metrics for the default metrics #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/prometheus_fastapi_instrumentator/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,22 +785,22 @@ def instrumentation(info: Info) -> None:

label_values = [
getattr(info, attribute_name)
for attribute_name in _map_label_name_value(total_label_names)
] + list(custom_labels.values())
for attribute_name in _map_label_name_value(total_label_names) + list(custom_labels.values())
]
TOTAL.labels(*label_values).inc()

label_values = [
getattr(info, attribute_name)
for attribute_name in _map_label_name_value(in_size_names)
] + list(custom_labels.values())
for attribute_name in _map_label_name_value(in_size_names) + list(custom_labels.values())
]
IN_SIZE.labels(*label_values).observe(
int(info.request.headers.get("Content-Length", 0))
)

label_values = [
getattr(info, attribute_name)
for attribute_name in _map_label_name_value(out_size_names)
] + list(custom_labels.values())
for attribute_name in _map_label_name_value(out_size_names) + list(custom_labels.values())
]
if info.response and hasattr(info.response, "headers"):
OUT_SIZE.labels(*label_values).observe(
int(info.response.headers.get("Content-Length", 0))
Expand All @@ -815,8 +815,8 @@ def instrumentation(info: Info) -> None:

label_values = [
getattr(info, attribute_name)
for attribute_name in _map_label_name_value(latency_lower_names)
] + list(custom_labels.values())
for attribute_name in _map_label_name_value(latency_lower_names) + list(custom_labels.values())
]
LATENCY_LOWR.labels(*label_values).observe(duration)

return instrumentation
Expand Down
Loading