Skip to content

257 internet up but GitHub unresponsive case only 98 gracefull #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025
Merged

257 internet up but GitHub unresponsive case only 98 gracefull #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f91fc2e
Adjust CPU for tests (#254)
fontikar Jan 28, 2025
59ae1ee
Minor fix: Updated R minimum version (#255)
fontikar Jan 28, 2025
157c6e7
Removing test that conflicts with the edge case handling approach pre…
wcornwell Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CRAN-SUBMISSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 1.1.2
Date: 2025-01-13 00:32:56 UTC
SHA: 7f8e98fe2a02afc75badcfeef54dfc901f690fe5
Date: 2025-01-28 03:02:05 UTC
SHA: f91fc2ec56112621d5517558a7df6f968e65195c
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Encoding: UTF-8
Language: en
LazyData: true
Depends:
R (>= 4.0.0),
R (>= 4.1.0),
Imports:
readr,
purrr,
Expand Down
5 changes: 3 additions & 2 deletions cran-comments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@

* This is a resubmission
* Improved handling for release tag versions from Github API
* Adding one user function for genus->family lookup

* Getting CPU elapsed limit for Debian but no parallelisation used in package
* Have set CPU thread limit manually for tests
* Updated R dependency
3 changes: 3 additions & 0 deletions tests/testthat.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
# * https://r-pkgs.org/tests.html
# * https://testthat.r-lib.org/reference/test_package.html#special-files

# Setting the CPU Thread limit to max 2 to meet CRAN guidelines.
Sys.setenv("OMP_THREAD_LIMIT" = 2)

library(testthat)
library(APCalign)

Expand Down
1 change: 0 additions & 1 deletion tests/testthat/test-versions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@ test_that("Retrieval is possible", {
versions <- get_versions()

expect_visible(versions)
expect_named(versions)
})

Loading