[pull] master from golang:master#150
Merged
Merged
Conversation
The disabledOnPlatform constant was hand-copied from x/telemetry/internal/telemetry until a public API became available. The vendored golang.org/x/telemetry/counter/countertest package now exports SupportedPlatform, so use it and delete the copy. This also picks up the mips/mipsle entries, which were added to DisabledOnPlatform in x/telemetry after the constant was copied here. For #66205 Change-Id: I9d4b6bb0939f0a32f78583d7a450167489a3d3be Reviewed-on: https://go-review.googlesource.com/c/go/+/802520 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
We're going to use these for the run cgo action once it's cached separately. Change-Id: I8c1ae6db015f89739a7f21525abd79e06a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/799900 Reviewed-by: Sean Liao <sean@liao.dev> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>
POSIX says you follow the symlink, but some platforms don't. Add OpenBSD to the list of ones that don't. Fixes #80386 Change-Id: Ifcfed66c934ba1ec74836f883dfba3f86a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/800700 Reviewed-by: Nicholas Husin <nsh@golang.org> Reviewed-by: Nicholas Husin <husin@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
LoweredZero on arm32 and s390x also take an end-of-zero-range address. That input is also an address sink. Also allow propagation of addresses from input to output of a value, so that we handle at least simple address arithmetic. This is required to fix riscv64 because it has no indexed load/store, and thus does a bunch more explicit address arithmetic than other archs. Fixes #80484 Change-Id: I126eec1e2cc6c2ab5a39611ccc4d3371dca28292 Reviewed-on: https://go-review.googlesource.com/c/go/+/803660 Reviewed-by: Junyang Shao <shaojunyang@google.com> Reviewed-by: David du Colombier <0intro@gmail.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Auto-Submit: Keith Randall <khr@golang.org>
When parsing an ECHConfigList, length fields were previously evaluated as a uint16. This would cause an infinite loop to occur when parsing a 65532 bytes long ECHConfig with a declared outer length header of 0. Triggering this condition requires a payload of at least 65538 bytes. As ECHConfigList payloads are typically delivered via protocols that limit them to 65535 bytes (DNS HTTPS records and TLS extensions), regular clients are safe from this issue. Thank you to Nguyễn Hoàng Hải (facebookmark2022@gmail.com) for reporting this issue. Fixes #80513 Change-Id: I8c5011d3b375c24794dd38b915bb4dc06a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/804040 Reviewed-by: Daniel McCarney <daniel@binaryparadox.net> Reviewed-by: Nicholas Husin <husin@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Roland Shoemaker <roland@golang.org>
Change-Id: Ibc7526823677cf8aa3769e79676b18d3a56dfd01 Reviewed-on: https://go-review.googlesource.com/c/go/+/803274 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Junyang Shao <shaojunyang@google.com>
The issue was fixed unintentionally by CL 767161. Fixes #80520 Change-Id: I212af69f0d7ccdc8e48f9a17e207de57be85e9e8 Reviewed-on: https://go-review.googlesource.com/c/go/+/804280 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Unlike what CL 778622 assumed, the default for cmd/go is whatever was set at the time of make.bash, not amd64.v1. To test this properly, use a value that's higher than what will reasonably be set. Updates #73294 Fixes #80525 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-goamd64v3 Change-Id: Ia8f9b9871ee9886201fa0a129c05a3636a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/804060 Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
This is intended to simplify tuning and experiments. Change-Id: I8ec2245b868fe4d508df1bc880c69568c90d8f93 Reviewed-on: https://go-review.googlesource.com/c/go/+/803700 Reviewed-by: Jakub Ciolek <jakub@ciolek.dev> Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )