Skip to content

Add support for Trac 1.6 and Python3 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add support for Trac 1.6 and Python3 #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d83a2f6
[runtests] Add a utility function to generate URLs
bmispelon Feb 1, 2024
385fc8d
[runtests] Created custom assertRequestRedirect test method
bmispelon Feb 1, 2024
bd8fd09
[runtests] Converted usage of urllib2 to requests
bmispelon Feb 1, 2024
c75efa5
[py3-compat] Use PyGIT.Storage.repo_path instead of shelling out to git
bmispelon Feb 3, 2024
100cc6b
[py3-compat] Used __future__ version of print()
bmispelon Feb 3, 2024
d02ea6c
[py3-compat] Only use str values for configparser
bmispelon Feb 3, 2024
6dc5a34
[py3-compat] Remove usage of dict.iteritems()
bmispelon Feb 3, 2024
657fd66
[py3-compat] Added py3 compatibility :tada:
bmispelon Feb 3, 2024
eccc5ba
Added Python3 classifiers in setup.py
bmispelon Feb 3, 2024
e5e949d
Added release note about py3 support
bmispelon Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions .github/workflows/runtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@ jobs:
- run: git config --global user.email runtest@localhost
- run: nox --non-interactive --error-on-missing-interpreter --session runtests -- --git-default-branch=master

# runtests-py3:
# runs-on: ubuntu-latest
# steps:
# - uses: wntrblm/[email protected]
# with:
# python-versions: "3.7"
# - uses: actions/checkout@v4
# - run: git config --global user.name runtest
# - run: git config --global user.email runtest@localhost
# - run: git config --global init.defaultBranch main
# - run: nox --non-interactive --error-on-missing-interpreter --session runtests
runtests-py3:
runs-on: ubuntu-latest

steps:
- uses: wntrblm/[email protected]
with:
python-versions: "3.7, 3.8, 3.9, 3.10, 3.11, 3.12" # duplicated in noxfile.py
- uses: actions/checkout@v4
- run: git config --global user.name runtest
- run: git config --global user.email runtest@localhost
- run: git config --global init.defaultBranch main
- run: nox --non-interactive --error-on-missing-interpreter --session runtests
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,7 @@ Changelog
* Add configuration option for path prefix of login and logout. (#127)
* Add `GitHubPolicy` permission policy to make `[timeline]`
`changeset_show_file` option work correctly. (#126)
* Support for Python3 (tested with 3.7 - 3.12) (requires Trac >= 1.6)

### 2.3

Expand Down
5 changes: 4 additions & 1 deletion noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@

if sys.version_info.major == 2:
TRAC_VERSIONS = ["1.4.4", "1.2.6"]
PYTHON_VERSIONS = ["2.7"]
else:
TRAC_VERSIONS = ["1.6"]
PYTHON_VERSIONS = ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"] # duplicated in runtests.yml


@nox.session
@nox.session(python=PYTHON_VERSIONS)
@nox.parametrize("trac", TRAC_VERSIONS)
def runtests(session, trac):
session.install("-r", "requirements_test.txt")
session.install("Trac==%s" % trac)
session.run("python", "--version")
session.run("python", "runtests.py", *session.posargs)
Loading
Loading