Support specifying a custom rails command #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #609 has been pretty silent, I'm not sure whether you would want to support specifying a custom command. I'm also not sure whether I covered all cases (probably not). However, these changes allow me to use the rails executable in a docker context and unblock me from not being able to use the plugin's full functionality.
I mainly need these changes to run our test suite. Our dev environment is configured to use a containerized database for testing. We also have a containerized redis instance tightly coupled to rails. So some functionality provided by the plugin would simply fail because rails can't reach the redis instance.
Fixes #609