implements conditionExpression instead of expression

[morloderex]

In order to use the CaseGroup expression as "top-level" expression we must implement \Illuminate\Contracts\Database\Query\ConditionExpression instead of expression.

Before:

where(new CaseGroup)

Generates an is null constraint at the end.

after this pr

where(new CaseGroup)

Does NOT generate an is null constraint at the end.

[tpetry]

This is not how CASE should be used: WHERE case ... end doesn't make any sense. This is like WHERE 1, wheres your condition?

[tpetry]

Please explain why you wanted to use it that way. Maybe there's a better approach. But CaseGroup will definitely not changed to be a ConditionExpression - as it is not a condition. It only generates a values.

[morloderex]

@tpetry

Here is my CaseGroup:

$query->where(
        new CaseGroup([
            new CaseRule(
                new Number(0),
                new Equal('role', new Value('tool')),
            ),
            new CaseRule(
                new Expression('JSON_LENGTH(`tool_calls`) = 0 OR `tool_calls` IS NULL'),
                new Equal('role', new Value('assistant')),
            ),
            new CaseRule(
                new Number(1),
                new Equal('role', new Value('user')),
            ),
        ])
    );

This is generating a 1 or a 0 depending the content of a column.

[morloderex]

It's about making it possible to do complex conditions.

[tpetry]

The code wouldn't even work on PG because an expression in the WHERE has to be a boolean and not a number. So the PR would (for your usecase) broken the promise this package does: make code portable.

@kohenkatz That won't work either on all databases.

@morloderex What you're trying to achieve looks like something completely doeable with normal where() conditions. I mean these are just different WHERE conditions that should be AND-ed or OR-ed?