Skip to content

Configurable formatter #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jan 10, 2022
Merged

Configurable formatter #171

merged 18 commits into from
Jan 10, 2022

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Apr 17, 2021 •
edited
Loading

Fixes #112

@gaborbernat gaborbernat force-pushed the configurable-formatter branch from 4b57cb9 to 1606593 Compare December 31, 2021 13:11
@gaborbernat
Copy link
Member

@flying-sheep I've rebased on main, can you please fix the CI, thanks!

@flying-sheep flying-sheep force-pushed the configurable-formatter branch from c1b8977 to 21cd974 Compare January 3, 2022 09:20
@flying-sheep flying-sheep force-pushed the configurable-formatter branch from 4fdb697 to 3eaf8d6 Compare January 3, 2022 09:28
@flying-sheep flying-sheep marked this pull request as ready for review January 3, 2022 09:29
gaborbernat
gaborbernat requested changes Jan 3, 2022
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing.

@gaborbernat gaborbernat marked this pull request as draft January 3, 2022 11:11
@flying-sheep flying-sheep marked this pull request as ready for review January 4, 2022 11:38
gaborbernat
gaborbernat requested changes Jan 4, 2022
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires test, changelog and documentation.

@gaborbernat gaborbernat marked this pull request as draft January 4, 2022 12:12
@flying-sheep
Copy link
Contributor Author

I’ll wait for the test module in #191 to land, that’ll make testing easier.

Can you please help with the tests there?

@flying-sheep flying-sheep marked this pull request as ready for review January 5, 2022 12:20
gaborbernat
gaborbernat requested changes Jan 6, 2022
View reviewed changes
@gaborbernat gaborbernat force-pushed the configurable-formatter branch from 3e6a36c to 1606593 Compare January 7, 2022 09:30
@gaborbernat
Copy link
Member

@flying-sheep can you please force push back 3e6a36c, I by mistake overwritten this branch. Thanks 🙏

@flying-sheep
Copy link
Contributor Author

All done!

gaborbernat
gaborbernat reviewed Jan 10, 2022
View reviewed changes
gaborbernat
gaborbernat requested changes Jan 10, 2022
View reviewed changes
src/sphinx_autodoc_typehints/__init__.py Outdated
Comment on lines 101 to 102
fully_qualified=fully_qualified,
simplify_optional_unions=simplify_optional_unions,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought let's pass in the app.config argument here as is. That way we'll not have to keep adding arguments in the future.

@gaborbernat
PR Feedback
2ab3ff2 
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat gaborbernat merged commit e2e780d into tox-dev:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow customizing formatter
2 participants
@flying-sheep @gaborbernat