Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate project to typescript #20

Merged
merged 50 commits into from
Mar 6, 2025
Merged

Migrate project to typescript #20

merged 50 commits into from
Mar 6, 2025

Conversation

tuna1207
Copy link
Member

@tuna1207 tuna1207 commented Oct 29, 2024

Motivation and Context

Migrate project to use typescript

Jira Link: https://toruslabs.atlassian.net/browse/PD-4011?atlOrigin=eyJpIjoiZDIyZGQ2NWY0ZTZmNDBlYmJiM2Y1NGZhZmE1MmIyMDEiLCJwIjoiaiJ9

Description

  • Update source code and build configuration to use typescript

The AdaptiveBroadcastChannel class is designed to add fallback during channel post message and synchronization issues between senders and receivers in a broadcast communication scenario. It achieves this by:

  • Creating a separate channel for each communication method, allowing all methods to listen simultaneously.
  • Implementing adaptive listening, where all instances listen on all channels but primarily use the current active method for sending.
  • Enabling seamless method switching, allowing receivers to automatically adapt to the sender's method changes without manual intervention.
  • This AdaptiveBroadcastChannel can be opt in by the user of the package

How has this been tested?

Tested with browser, e2e test cases

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@hieu-w hieu-w force-pushed the feat/typescript branch 2 times, most recently from 12ed1ad to cc2e0e8 Compare March 2, 2025 17:32
@hieu-w hieu-w force-pushed the feat/typescript branch from cb71e3a to bd2e2e8 Compare March 2, 2025 18:55
@hieu-w hieu-w force-pushed the feat/typescript branch from 3fb7a31 to 78ca131 Compare March 2, 2025 19:14
@hieu-w hieu-w force-pushed the feat/typescript branch from eecf299 to 287345e Compare March 3, 2025 02:37
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 84be259 into master Mar 6, 2025
4 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/typescript branch March 6, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants