Skip to content

Set follow_redirects to False for websocket connections to prevent si… #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch5.1
Choose a base branch
from
Open

Set follow_redirects to False for websocket connections to prevent si… #2876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tornado/websocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,6 +1334,10 @@ def websocket_connect(url, callback=None, connect_timeout=None,
request = httpclient.HTTPRequest(url, connect_timeout=connect_timeout)
request = httpclient._RequestProxy(
request, httpclient.HTTPRequest._DEFAULTS)

# Websocket connection is currently unable to follow redirects
# Set follow_redirects to False to prevent a silent failure
request.follow_redirects = False
conn = WebSocketClientConnection(request,
on_message_callback=on_message_callback,
compression_options=compression_options,
Expand Down