Jinja support #247
Closed
Jinja support #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rary into jinja * 'main' of https://github.com/torchbox/django-pattern-library: Add Python 3.12 to the test matrix, drop Django 4.1 (torchbox#242) Updates for version 1.2.0 Improve handling of non-string values for 'override_tag's 'default_html' argument (torchbox#224) fix: make it work for django5.0 (updated) (torchbox#241) Upgrade GitHub Actions versions (torchbox#237) Fix typos discovered by codespell (torchbox#238)
Upgrade Jinja support to work with Django 5
|
@thibaudcolas / @zerolab Gentle ping to see this. I've updated this branch to the latest. |
|
@CuriousLearner I’m in the process of testing this – it feels very close! |
thibaudcolas
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
As far as I can see this largely works as expected, however it’s missing documentation, tests, and support for tags overrides. I think this can get merged as-is (or close), but I will have to mention Jinja support as "experimental" until we have better tests for it.
| @@ -46,7 +46,7 @@ exclude = [ | |||
| python = "^3.8" | |||
| Django = ">=3.2,<5.1" | |||
| PyYAML = ">=5.1,<7.0" | |||
| Markdown = "^3.1" | |||
| Markdown = "^3.5.1" | |||
thibaudcolas
added
enhancement
|
Shipped in #254! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Jinja support to the django-pattern-library. It is based on @gone's work and will superseed #206.
Fixes #171 -> Discussion #180
Checklist