Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-JIRA] Fixing issue with yarn install and Minor Changes #388

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

cust0m
Copy link
Contributor

@cust0m cust0m commented Mar 4, 2025

Fixing issue with yarn install and Minor Changes

Description

  • fix issues with yarn-install action
  • remove GCR_ACCOUNT_KEY from envVar for build-push-image action
  • remove "Login to Google Artifact Registry - GAR" step from the same action and replace it with "Set up Docker login"

How to test

  • FIXME: Add the steps describing how to verify your changes

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping teams for review

@cust0m cust0m requested a review from a team as a code owner March 4, 2025 22:55
Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 93139cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cust0m cust0m changed the title [NO-JIRA] Testing yarn-install [NO-JIRA] Minor Changes Mar 6, 2025
@cust0m cust0m changed the title [NO-JIRA] Minor Changes [NO-JIRA] Fixing issue with yarn install and Minor Changes Mar 6, 2025
@cust0m cust0m merged commit 3e6ded0 into master Mar 6, 2025
5 checks passed
@cust0m cust0m deleted the no-jira-testing-yarn-install branch March 6, 2025 13:03
@github-actions github-actions bot mentioned this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants