Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add action to get slack name based on email #117

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

denieler
Copy link
Contributor

@denieler denieler commented Feb 10, 2023

Description

Add github action to retrieve slack name from user email

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

@denieler denieler requested a review from a team February 10, 2023 14:48
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2023

🦋 Changeset detected

Latest commit: aa42b4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the contribution DO NOT ADD MANUALLY label Feb 10, 2023
@toptal-devbot
Copy link

Greetings from FX team, @denieler 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good 👍, could you please also share the use case that we try to cover?

@denieler
Copy link
Contributor Author

the code looks good 👍, could you please also share the use case that we try to cover?

@TomasSlama yes, I want to send slack messages to people, based on some GHA checks (which have only GH user emails/nicknames)

@denieler
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Collaborator

@dmaklygin dmaklygin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thank you

@denieler denieler merged commit 0f78c59 into master Feb 14, 2023
@denieler denieler deleted the cp-add-get-user-slack branch February 14, 2023 08:48
@github-actions github-actions bot mentioned this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY no-jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants