[PROD] - Copilot Portal fixes and updates #838

kkartunov · 2025-07-28T06:52:33Z

https://topcoder.atlassian.net/browse/PM-1291
https://topcoder.atlassian.net/browse/PM-1522

fix(PM-1468): make notes mandatory

fix(PM-1368, PM-1394): group by active and then sort by createdAt

…unity-title PM-1498 - support for opportunity title

fix(PM-1494): Add extra info for copilot email

…equest PM-1499 edit copilot request

fix(PM-1510): added existing membership to the copilot application

github-actions · 2025-07-30T20:58:41Z

src/routes/copilotOpportunity/assign.js

@@ -45,11 +49,17 @@ module.exports = [
        throw err;
      }

+      const copilotRequest = await models.CopilotRequest.findOne({


Consider handling the case where copilotRequest might be null or undefined after the findOne query. This could prevent potential runtime errors if the expected data is not found.

github-actions · 2025-07-30T20:58:41Z

src/routes/copilotOpportunity/assign.js

+        where: { id: opportunity.copilotRequestId },
+        transaction: t,
+      });
+
      const application = await models.CopilotApplication.findOne({


Ensure that the application object is properly validated before proceeding with operations that depend on its properties. This will help avoid errors if the findOne query does not return the expected result.

github-actions · 2025-07-30T20:58:46Z

src/routes/copilotOpportunity/assign.js

+        });
+
+        req.log.debug(`All updations done`);
+        transaction.commit();


Consider using await transaction.commit() to ensure the transaction is properly awaited and any potential errors are caught.

github-actions · 2025-07-30T20:58:46Z

src/routes/copilotOpportunity/assign.js

+          transaction,
+        });
+
+        req.log.debug(`Updating other applications: ${JSON.stringify(copilotRequest)}`);


The debug log message here is misleading. It mentions updating 'other applications' but logs the copilotRequest object. Consider updating the log message to accurately reflect the action being performed.

github-actions · 2025-07-30T20:58:46Z

src/routes/copilotOpportunity/assign.js

+              $ne: application.id,
+            },
+          }
+        });


Consider adding a transaction option to the CopilotApplication.update call to ensure it is part of the same transaction as the other updates.

github-actions · 2025-07-30T20:58:46Z

src/routes/copilotOpportunity/assign.js

+        req.log.debug(`Email sent`);
+      };
+
+      const existingMember = activeMembers.find(item => item.userId === userId);


The variable existingMember is used here, but it is essentially the same as existingUser from the removed code. Ensure that the logic for finding the existing member is correct and consistent with the previous implementation.

github-actions · 2025-07-30T20:58:51Z

src/routes/copilotOpportunityApply/list.js

+      where: {
+        id: opportunityId,
+      }
+    }).then((opportunity) => {


Consider adding a timeout or handling for the promise returned by models.CopilotOpportunity.findOne to prevent potential hanging if the database query takes too long.

github-actions · 2025-07-30T20:58:51Z

src/routes/copilotOpportunityApply/list.js

+      }
+    }).then((opportunity) => {
+      if (!opportunity) {
+        const err = new Error('No opportunity found');


The error message 'No opportunity found' could be more descriptive by including the opportunityId to help with debugging.

github-actions · 2025-07-30T20:58:51Z

src/routes/copilotOpportunityApply/list.js

+      })
+        .then(copilotApplications => {
+          req.log.debug(`CopilotApplications ${JSON.stringify(copilotApplications)}`);
+          return models.ProjectMember.getActiveProjectMembers(opportunity.projectId).then((members) => {


Consider adding error handling for the promise returned by models.ProjectMember.getActiveProjectMembers to ensure that any issues fetching project members are properly managed.

github-actions · 2025-07-30T20:58:51Z

src/routes/copilotOpportunityApply/list.js

+            req.log.debug(`Fetched existing active members ${JSON.stringify(members)}`);
+            req.log.debug(`Applications ${JSON.stringify(copilotApplications)}`);
+            const enrichedApplications = copilotApplications.map(application => {
+              const m = members.find(m => m.userId === application.userId);


The variable m could be renamed to something more descriptive, such as member, to improve code readability.

github-actions · 2025-07-30T20:58:51Z

src/routes/copilotOpportunityApply/list.js

+              return enriched;
+            });
+
+            req.log.debug(`Enriched Applications ${JSON.stringify(enrichedApplications)}`);


Consider using res.json(enrichedApplications) instead of res.status(200).send(enrichedApplications) for consistency with the previous implementation and to automatically set the correct content-type header.

github-actions · 2025-07-30T20:58:55Z

src/routes/projectMembers/update.js

+    req.log.debug(`Sent email to ${member.email}`);
+  });
+};
+


The removal of _transaction.commit() may lead to uncommitted changes in the database. Ensure that the transaction is being committed elsewhere or that this removal is intentional and safe.

github-actions · 2025-07-30T20:58:57Z

src/routes/projectMembers/update.js

        projectMember = projectMember.get({ plain: true });
        projectMember = _.omit(projectMember, ['deletedAt']);
+
+        if (['observer', 'customer'].includes(previousValue.role) && ['copilot', 'manager'].includes(updatedProps.role)) {


The condition has been changed from checking updatedProps.role to previousValue.role. Ensure that this change aligns with the intended logic and that previousValue.role is correctly defined and used in this context.

github-actions · 2025-07-30T20:58:57Z

src/routes/projectMembers/update.js

        projectMember = projectMember.get({ plain: true });
        projectMember = _.omit(projectMember, ['deletedAt']);
+
+        if (['observer', 'customer'].includes(previousValue.role) && ['copilot', 'manager'].includes(updatedProps.role)) {
+          await completeAllCopilotRequests(req, projectId, _transaction, projectMember);


The variable _member has been replaced with projectMember. Verify that projectMember is the correct variable to use in this function call and that it contains the necessary data.

Deploy - PM-1314

github-actions · 2025-07-31T05:14:11Z

.circleci/config.yml

@@ -149,7 +149,7 @@ workflows:
          context : org-global
          filters:
            branches:
-              only: ['develop', 'migration-setup', 'pm-1378']
+              only: ['develop', 'migration-setup', 'PM-1314']


The branch name 'PM-1314' should be verified to ensure it is correct and intended for production deployment. If this is a typo or incorrect branch, it may lead to unintended deployments.

PM-1314 Make grouping by status optional

github-actions · 2025-07-31T13:22:39Z

src/routes/copilotOpportunity/list.js

@@ -21,6 +21,25 @@ module.exports = [
    const pageSize = parseInt(req.query.pageSize, 10) || DEFAULT_PAGE_SIZE;
    const offset = (page - 1) * pageSize;
    const limit = pageSize;
+    const noGroupingByStatus = req.query.noGrouping === 'true';


Consider using a more descriptive variable name than noGroupingByStatus to improve code readability. For example, disableStatusGrouping might better convey the purpose of the variable.

github-actions · 2025-07-31T13:22:39Z

src/routes/copilotOpportunity/list.js

+        'ASC',
+      ]);
+    }
+    baseOrder.push([sortParams[0], sortParams[1]]);


Ensure sortParams is validated before being used in baseOrder.push([sortParams[0], sortParams[1]]); to prevent potential runtime errors if sortParams is not an array or does not contain the expected elements.

fix(PM-1398): Dont allow invite to be accepted when the opportunity is closed

github-actions · 2025-08-01T06:49:37Z

src/routes/copilotRequest/approveRequest.service.js

@@ -42,11 +45,14 @@ module.exports = (req, data, existingTransaction) => {
                where: {
                  projectId,
                  type: data.type,
+                  status: {
+                    [Op.in]: [COPILOT_OPPORTUNITY_STATUS.ACTIVE],


The change from [Op.notIn]: [COPILOT_REQUEST_STATUS.CANCELED] to [Op.in]: [COPILOT_OPPORTUNITY_STATUS.ACTIVE] alters the logic to only consider active opportunities instead of excluding canceled ones. Ensure this change aligns with the intended functionality and does not inadvertently exclude other statuses that should be considered.

github-actions · 2025-08-01T06:49:39Z

src/routes/projectMemberInvites/update.js

@@ -46,7 +50,7 @@ module.exports = [

    // get invite by id and project id
    return models.ProjectMemberInvite.getPendingOrRequestedProjectInviteById(projectId, inviteId)
-      .then((invite) => {
+      .then(async (invite) => {


The function has been changed to an async function, but there is no await keyword used within the function body. If there are asynchronous operations intended to be awaited, ensure to use the await keyword where necessary. Otherwise, consider if the async keyword is needed.

github-actions · 2025-08-01T06:49:43Z

src/routes/projectMemberInvites/update.js

@@ -81,6 +85,31 @@ module.exports = [
          return next(err);
        }

+        // Check if the copilot opportunity is still active
+        // When the invited user tries to accept the invite
+        if (invite.applicationId) {


Consider adding a check to ensure invite.applicationId is valid before proceeding with the database query. This will prevent unnecessary database calls if applicationId is null or undefined.

github-actions · 2025-08-01T06:49:43Z

src/routes/projectMemberInvites/update.js

+            }
+          });
+
+          const opportunity = await models.CopilotOpportunity.findOne({


Add error handling for the case where application is not found. This will prevent potential null reference errors when accessing application.opportunityId.

github-actions · 2025-08-01T06:49:43Z

src/routes/projectMemberInvites/update.js

+            },
+          });
+
+          req.log.debug(`Copilot opportunity status: ${opportunity.status}`);


Add error handling for the case where opportunity is not found. This will prevent potential null reference errors when accessing opportunity.status.

fix(PM-1398): cancel invites on canceling the copilot opportunity

github-actions · 2025-08-01T15:44:02Z