Skip to content

Fix for WIpro login in prod #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2025
Merged

Fix for WIpro login in prod #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/api/user/validation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,6 +821,7 @@ export class ValidationService {
select: { user_id: true },
});
}
console.log("Looking for user ID: " + profile.userId);
Copy link

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
Using console.log for logging is not recommended in production code. Consider using the existing Logger instance for consistent logging and better control over log levels.

// getUserIdBySSOUserId
if (!ssoLink && profile.userId) {
ssoLink = await this.prismaClient.user_sso_login.findFirst({
Expand Down
4 changes: 2 additions & 2 deletions src/core/constant/provider-type.enum.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@ export const ProviderTypes: Record<string, ProviderDetails> = {
isSocial: false,
isEnterprise: true,
},
adfs: {
"wipro-adfs": {
Copy link

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Changing the provider key from adfs to wipro-adfs may impact existing integrations or configurations that rely on the old key. Ensure that all references to this provider key are updated throughout the codebase and any external systems that interact with it.

id: ProviderId.ADFS,
key: 'adfs',
key: 'wipro-adfs',
isSocial: false,
isEnterprise: true,
},
Expand Down