Skip to content

fix(PM-716): used promisify instead of sync file read API #7071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

hentrymartin
Copy link
Collaborator

What's in this PR?

  • Used promisify instead of sync file read API which should resolve path manipulation issue.

@hentrymartin hentrymartin requested review from jmgasper, vas3a and kkartunov and removed request for ajefts and luizrrodrigues February 17, 2025 23:04
@kkartunov
Copy link
Collaborator

@hentrymartin we need to keep eye on this and avoid errors like "cannot read property 'stat' of undefined".
See: 542b81e
Not sure if related to promisify or fs module but we had this issue in production when released v1 security fixes.

@hentrymartin
Copy link
Collaborator Author

@hentrymartin we need to keep eye on this and avoid errors like "cannot read property 'stat' of undefined". See: 542b81e Not sure if related to promisify or fs module but we had this issue in production when released v1 security fixes.

@kkartunov Seems like the error which you quoted is not because of promisify but we forgot to add import statement for fs and thats why it was failed. With this being in mind, do we still need to remove promisify?

@hentrymartin hentrymartin merged commit bef0398 into develop Feb 19, 2025
4 checks passed
@hentrymartin hentrymartin deleted the pm-716 branch February 19, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants