Skip to content

Search only searching in challenge spec and not title #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SathyaJayabal opened this issue Feb 23, 2021 · 13 comments
Open

Search only searching in challenge spec and not title #390

SathyaJayabal opened this issue Feb 23, 2021 · 13 comments

Comments

@SathyaJayabal
Copy link
Collaborator

@rootelement , when we search for a specific term, challenge api returns only when search term is found in the challenge description. It does not consider title. This was working fine before.

Example:
Screenshot 2021-02-23 at 10 51 07 AM
Screenshot 2021-02-23 at 10 51 23 AM

@ThomasKranitsas
Copy link
Contributor

@SathyaJayabal in order to fix/improve our search functionality, can you please create a list of expected search queries and results along with a simple explanation so we can improve our code? Something like:

  • Searching for node API should return Implement an API using NodeJs. Explanation: all query terms are partially present in any order

We need as many use case scenarios as possible so we build a strong searching mechanism.

@rootelement
Copy link
Contributor

Might be a question for @Oanh-and-only-Oanh as well.

@ThomasKranitsas
Copy link
Contributor

@SathyaJayabal @Oanh-and-only-Oanh any update here?

@SathyaJayabal
Copy link
Collaborator Author

@ThomasKranitsas , the basic search which was working before is :
Searching for node API should return challenges which have the words node API either in the title or the description(contest spec).

@Oanh-and-only-Oanh , please add any further requirements.

@ThomasKranitsas
Copy link
Contributor

ThomasKranitsas commented Mar 22, 2021

IMHO, searching for node API should return challenges that:

  1. have the node API in the title (case insensitive)
  2. OR have the node API in the description (case insensitive)
  3. OR have the tag node (partial match - case insensitive)
  4. OR have the tag API (partial match - case insensitive)

we could make this more advanced by extracting all words in step 1 and use them separately as a query with lower weight so we can also match things like Implement an API using NodeJS (both terms are present but in a different order)

Let me know if we should implement the search this way

@rootelement
Copy link
Contributor

I almost think the weight should be:

  1. Title Exact Match Phrase
  2. Tag exact match
  3. Description Exact Match
  4. Title Fuzzy Match (tokenized)
  5. Tag Fuzzy
  6. Description Fuzzy

@Oanh-and-only-Oanh
Copy link

I agree with @rootelement but as a minimum we'd like it to return challenges which has the search terms either in the title or the description(contest spec).

@Oanh-and-only-Oanh
Copy link

@rootelement @ThomasKranitsas, when will this fixed be released?

@ThomasKranitsas
Copy link
Contributor

@Oanh-and-only-Oanh there's a PR #428 for this.

@rootelement should we merge that to prod?

@rootelement
Copy link
Contributor

This was pushed to prod earlier today

@SathyaJayabal
Copy link
Collaborator Author

@ThomasKranitsas, still search does not return the challenge when we search by a word in the challenge title
Screenshot 2021-07-16 at 9 42 55 AM
Screenshot 2021-07-16 at 9 43 16 AM

@SathyaJayabal
Copy link
Collaborator Author

@ThomasKranitsas , search is now not returning when the search term is found in a tag.

For example, when we click on any of the tags for a challenge in listings page, it doesn't return any results.
Screenshot 2021-09-28 at 11 52 32 AM

@SathyaJayabal
Copy link
Collaborator Author

cc @luizrrodrigues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants