Refactor for additional_data to custom_dimensions

tonicpow · Jan 15, 2020 · 57b6a3e · 57b6a3e
1 parent d74bab2
commit 57b6a3e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/examples/examples.js b/examples/examples.js
@@ -249,7 +249,7 @@ let apiKey = process.env.TONICPOW_API_KEY || ''
     //
     let visitorSession = {
       link_id: link.id,
-      additional_data: "any custom data attributes",
+      custom_dimensions: "any custom data attributes",
     }
     visitorSession = await TonicPow.createVisitorSession(visitorSession)
     console.log('session created', visitorSession.tncpw_session)

diff --git a/lib/api.js b/lib/api.js
@@ -653,24 +653,24 @@ async function getConversion (t, conversionId) {
 // createConversionByGoalID will fire a conversion for a given goal id, if successful it will make a new Conversion
 //
 // For more information: https://docs.tonicpow.com/#caeffdd5-eaad-4fc8-ac01-8288b50e8e27
-async function createConversionByGoalID (t, goalId, tncpwSession, optionalData = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
-  let data = { goal_id: goalId, tncpw_session: tncpwSession, additional_data: optionalData, delay_in_minutes: delayInMinutes, amount: optionalPurchaseAmount }
+async function createConversionByGoalID (t, goalId, tncpwSession, customDimensions = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
+  let data = { goal_id: goalId, tncpw_session: tncpwSession, custom_dimensions: customDimensions, delay_in_minutes: delayInMinutes, amount: optionalPurchaseAmount }
   return tonicAxios.post(t.config.apiUrl + version + '/conversions', data, getOptions())
 }
 
 // createConversionByGoalName will fire a conversion for a given goal name, if successful it will make a new Conversion
 //
 // For more information: https://docs.tonicpow.com/#d19c9850-3832-45b2-b880-3ef2f3b7dc37
-async function createConversionByGoalName (t, goalName, tncpwSession, optionalData = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
-  let data = { name: goalName, tncpw_session: tncpwSession, additional_data: optionalData, delay_in_minutes: delayInMinutes, amount: optionalPurchaseAmount }
+async function createConversionByGoalName (t, goalName, tncpwSession, customDimensions = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
+  let data = { name: goalName, tncpw_session: tncpwSession, custom_dimensions: customDimensions, delay_in_minutes: delayInMinutes, amount: optionalPurchaseAmount }
   return tonicAxios.post(t.config.apiUrl + version + '/conversions', data, getOptions())
 }
 
 // createConversionByUserID will fire a conversion for a given goal and user id, if successful it will make a new Conversion
 //
 // For more information: https://docs.tonicpow.com/#d724f762-329e-473d-bdc4-aebc19dd9ea8
-async function createConversionByUserID (t, goalId, userId, optionalData = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
-  let data = { goal_id: goalId, user_id: userId, additional_data: optionalData, delay_in_minutes: delayInMinutes, amount: optionalPurchaseAmount }
+async function createConversionByUserID (t, goalId, userId, customDimensions = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
+  let data = { goal_id: goalId, user_id: userId, custom_dimensions: customDimensions, delay_in_minutes: delayInMinutes, amount: optionalPurchaseAmount }
   return tonicAxios.post(t.config.apiUrl + version + '/conversions', data, getOptions())
 }
 
@@ -1119,33 +1119,33 @@ module.exports = {
       }
     })
   },
-  createConversionByGoalID: async function (goalId, tncpwSession, optionalData = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
+  createConversionByGoalID: async function (goalId, tncpwSession, customDimensions = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
     return new Promise(async (resolve, reject) => {
       try {
         initCheck(this.loaded)
-        let response = await createConversionByGoalID(this, goalId, tncpwSession, optionalData, optionalPurchaseAmount, delayInMinutes)
+        let response = await createConversionByGoalID(this, goalId, tncpwSession, customDimensions, optionalPurchaseAmount, delayInMinutes)
         resolve(response.data)
       } catch (e) {
         reject(checkError(e))
       }
     })
   },
-  createConversionByGoalName: async function (goalName, tncpwSession, optionalData = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
+  createConversionByGoalName: async function (goalName, tncpwSession, customDimensions = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
     return new Promise(async (resolve, reject) => {
       try {
         initCheck(this.loaded)
-        let response = await createConversionByGoalName(this, goalName, tncpwSession, optionalData, optionalPurchaseAmount, delayInMinutes)
+        let response = await createConversionByGoalName(this, goalName, tncpwSession, customDimensions, optionalPurchaseAmount, delayInMinutes)
         resolve(response.data)
       } catch (e) {
         reject(checkError(e))
       }
     })
   },
-  createConversionByUserID: async function (goalId, userId, optionalData = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
+  createConversionByUserID: async function (goalId, userId, customDimensions = '', optionalPurchaseAmount = 0.00, delayInMinutes = 0) {
     return new Promise(async (resolve, reject) => {
       try {
         initCheck(this.loaded)
-        let response = await createConversionByUserID(this, goalId, userId, optionalData, optionalPurchaseAmount, delayInMinutes)
+        let response = await createConversionByUserID(this, goalId, userId, customDimensions, optionalPurchaseAmount, delayInMinutes)
         resolve(response.data)
       } catch (e) {
         reject(checkError(e))

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tonicpow-js",
-  "version": "0.1.39",
+  "version": "0.1.40",
   "description": "TonicPow API Library in JS - https://docs.tonicpow.com",
   "main": "lib/api.js",
   "repository": {