-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add toncoin processing #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore payments/toncoin.mdx |
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore payments/toncoin.mdx |
|
/review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thoughtful update — I left a couple of suggestions in payments/toncoin.mdx; please apply the inline suggestions.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore payments/toncoin.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. In payments/toncoin.mdx, a couple of suggestions to align safety callouts—please apply the inline suggestions.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore payments/toncoin.mdx |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore payments/toncoin.mdx |
anton-trunov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great content!
A couple of points, though:
- looks like we should recommend the unique deposit address as the go-to solution;
- we need to include a subsection on what NOT to do when doing Toncoin processing: one thing that comes to mind is "do not send funds to nonexistent accounts without making sure you can later deploy a contract at that address, otherwise you will freeze those money in that uninit account"; is there anything else to warn against?
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore payments/toncoin.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR—spotted a couple of style issues in payments/toncoin.mdx; please apply the inline suggestions.
Closes #204