Skip to content

Conversation

@Shvandre
Copy link
Collaborator

Closes #986

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as resolved.

@Shvandre Shvandre marked this pull request as ready for review October 30, 2025 10:53
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No documentation issues detected.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

skywardboundd
skywardboundd previously approved these changes Oct 31, 2025
Copy link
Collaborator

@skywardboundd skywardboundd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best article I've ever seen

@Shvandre
Copy link
Collaborator Author

Diagram is not perfect. The only idea to improve that is to do #1075 with Aigerim

@Shvandre Shvandre marked this pull request as ready for review October 31, 2025 16:13
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update—I've left a couple of inline suggestions in docs.json and foundations; please apply them.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions

This comment was marked as outdated.

Copy link
Collaborator

@verytactical verytactical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flow of the article is unclear. (TL/DR: didn't understand a thing.)

We've pushed some more comments directly into the branch.

import { Stub } from '/snippets/stub.jsx';

<Stub issue="171" />
<Stub
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this article called "adnl", but its title is "Consensus"?

import { Stub } from '/snippets/stub.jsx';

<Stub issue="171" />
<Stub
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's important enough to be listed between "Messages" and "Account status".

### Example message flow

```mermaid
flowchart LR
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Which part of this image is unclear?" :)

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All message-related schemes should be in the same formatting, and every additional scheme adds context to what kind of design should be defined. So thanks to @Shvandre, he created another one.

For me, the unclear part starts from:

  1. Appearing crossing lines make this more complicated.
  2. Hard to get a timeline of events.

@verytactical verytactical marked this pull request as draft November 4, 2025 10:13
@Shvandre Shvandre requested a review from Karkarmath November 5, 2025 12:34
@reveloper reveloper requested a review from andreypfau November 6, 2025 08:04
- how to fetch dependencies;
- how to detect and penalize nodes that try to disrupt the system.

## Choosing neighbor nodes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Choosing neighbor" is part of overlay network protocol, not catchain

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore foundations/consensus/bcp-deep-dive.mdx foundations/consensus/bcp-overview.mdx foundations/consensus/catchain-overview.mdx foundations/network/adnl.mdx 


<Aside type="tip">
In the current implementation, [Mersenne Twister](https://en.wikipedia.org/wiki/Mersenne_Twister) is used to pick the random interval for refreshing the neighbor list. It is seeded with values from [std::random_device](https://en.cppreference.com/w/cpp/numeric/random/random_device.html), whose behavior is platform-dependent.
In the current implementation, [Mersenne Twister](https://en.wikipedia.org/wiki/Mersenne_Twister) is used to pick the random interval for refreshing the neighbor list. It is seeded with values from [std::random\_device](https://en.cppreference.com/w/cpp/numeric/random/random_device.html), whose behavior is platform-dependent.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the current implementation, [Mersenne Twister](https://en.wikipedia.org/wiki/Mersenne_Twister) is used to pick the random interval for refreshing the neighbor list. It is seeded with values from [std::random\_device](https://en.cppreference.com/w/cpp/numeric/random/random_device.html), whose behavior is platform-dependent.
In the current implementation, [Mersenne Twister](https://en.wikipedia.org/wiki/Mersenne_Twister) is used to pick the random interval for refreshing the neighbor list. It is seeded with values from [`std::random_device`](https://en.cppreference.com/w/cpp/numeric/random/random_device.html), whose behavior is platform-dependent.

Since its a code ref, let's use backticks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Foundations > Consensus] Catchain-overview

7 participants