🛡️ Sentinel: [CRITICAL] Fix path traversal in checksum and UploadId#102
Closed
tomdesair wants to merge 2 commits into
Closed
🛡️ Sentinel: [CRITICAL] Fix path traversal in checksum and UploadId#102tomdesair wants to merge 2 commits into
tomdesair wants to merge 2 commits into
Conversation
🚨 Severity: CRITICAL 💡 Vulnerability: Path traversal vulnerability allowed files to be read and created outside the designated upload directory. Checksum fields and UploadId values weren't validated against common path traversal characters like `..`, `/` or `\`. 🎯 Impact: Arbitrary file write/overwrite and read outside of the intended app directories. 🔧 Fix: - Added `isSafePathComponent` helper method in `AbstractDiskBasedService.java` to block unsafe inputs. - Validated `UploadId` inputs in `AbstractDiskBasedService.getPathInStorageDirectory`. - Verified `checksum` values in `DiskStorageService` functions (`getUploadInfoByChecksum`, `update`, `terminateUpload`) prior to attempting filesystem operations. - Added comprehensive unit test coverage (`testUnsafeChecksumValue`, `testGetUploadInfoByChecksumUnsafe`, `testPathTraversalUploadIdEncoded`) to enforce validation. ✅ Verification: Ran unit tests to ensure safe path operations complete and path traversal attempts raise expected exceptions (`IOException`, `IllegalArgumentException`). Code formatting passes checkstyle. Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🚨 Severity: CRITICAL
💡 Vulnerability: Path traversal vulnerability allowed files to be read and created outside the designated upload directory. Checksum fields and UploadId values weren't validated against common path traversal characters like `..`, `/` or `\`.
🎯 Impact: Arbitrary file write/overwrite and read outside of the intended app directories.
🔧 Fix:
- Added `isSafePathComponent` helper method in `AbstractDiskBasedService.java` to block unsafe inputs.
- Validated `UploadId` inputs in `AbstractDiskBasedService.getPathInStorageDirectory`.
- Verified `checksum` values in `DiskStorageService` functions (`getUploadInfoByChecksum`, `update`, `terminateUpload`) prior to attempting filesystem operations.
- Fixed `DiskLockingServiceTest.testRequestLockReleaseCreatesParentDirectory` and removed `.resolve("subdir")` testing invalid upload ids since it now throws an error.
- Added comprehensive unit test coverage (`testUnsafeChecksumValue`, `testGetUploadInfoByChecksumUnsafe`, `testPathTraversalUploadIdEncoded`) to enforce validation.
✅ Verification: Ran unit tests to ensure safe path operations complete and path traversal attempts raise expected exceptions (`IOException`, `IllegalArgumentException`). Code formatting passes checkstyle.
Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛡️ Sentinel: [CRITICAL] Fix path traversal in checksum and UploadId
🚨 Severity: CRITICAL
💡 Vulnerability: Path traversal vulnerability allowed files to be read and created outside the designated upload directory. Checksum fields and UploadId values weren't validated against common path traversal characters like
..,/or\.🎯 Impact: Arbitrary file write/overwrite and read outside of the intended app directories.
🔧 Fix:
isSafePathComponenthelper method inAbstractDiskBasedService.javato block unsafe inputs.UploadIdinputs inAbstractDiskBasedService.getPathInStorageDirectory.checksumvalues inDiskStorageServicefunctions (getUploadInfoByChecksum,update,terminateUpload) prior to attempting filesystem operations.testUnsafeChecksumValue,testGetUploadInfoByChecksumUnsafe,testPathTraversalUploadIdEncoded) to enforce validation.✅ Verification: Ran unit tests to ensure safe path operations complete and path traversal attempts raise expected exceptions (
IOException,IllegalArgumentException). Code formatting passes checkstyle.PR created automatically by Jules for task 10565677734019531756 started by @tomdesair