Answer: 59 #1267
Open
Answer: 59 #1267
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomalaforge
reviewed
Apr 3, 2025
| { | ||
| injector: this.#injector, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
very imperative, you could use a condition to trigger or not the request inside httpRessource.
There was a problem hiding this comment.
yep definitely I'll add a function to get a dynamic URL with a ternary condition
tomalaforge
reviewed
Apr 3, 2025
| expanded = output<boolean>(); | ||
| constructor() { | ||
| effect(() => { | ||
| this.expanded.emit(this.isExpanded()); |
There was a problem hiding this comment.
Using effect to trigger an output is often a sign of a bad design
There was a problem hiding this comment.
understood, I'll set a callback function for the button click instead
kevinagus
force-pushed
the
59-content-projection-defer
branch
from
c85b2c6 to
5b6b267
Compare
kevinagus
force-pushed
the
59-content-projection-defer
branch
from
5b6b267 to
5f8c1b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.