tracing: simplify common case of immediately entering the span (#1252) #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
force-pushed
the
eliza/backport-1252
branch
from
5b9b0af to
c60dfa8
Compare
davidbarsky
approved these changes
Feb 23, 2021
* Simplify common case of immediately entering the span
This PR allows the following API:
```
let _guard = tracing::span!("foo").entered();
```
See #1246 for an extended
discussion.
* Add missing inlines
This fns are monomorphic, so an `#[inline]` is necessary to alow
cross-crate inlining at all.
* improve method documentation
Co-authored-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
force-pushed
the
eliza/backport-1252
branch
from
c60dfa8 to
327a7a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports PR #1252 from
master. I'll go ahead and merge thispending CI.
This PR allows the following API:
See #1246 for an extended
discussion.
This fns are monomorphic, so an
#[inline]is necessary to alowcross-crate inlining at all.
Co-authored-by: Eliza Weisman [email protected]
Signed-off-by: Eliza Weisman [email protected]