feat(tokio_util): Stabilise JoinMap #7075
Conversation
conradludgate
force-pushed
the
conrad/stabalise-joinmap
branch
2 times, most recently
from
eb9f646 to
5155239
Compare
conradludgate
changed the title
conradludgate
force-pushed
the
conrad/stabalise-joinmap
branch
from
5155239 to
91695b2
Compare
Darksonn
changed the title
tokio-util/Cargo.toml
Outdated
|
|
||
| net = ["tokio/net"] | ||
| compat = ["futures-io",] | ||
| codec = [] | ||
| time = ["tokio/time","slab"] | ||
| io = [] | ||
| io-util = ["io", "tokio/rt", "tokio/io-util"] | ||
| rt = ["tokio/rt", "tokio/sync", "futures-util", "hashbrown"] | ||
| rt = ["tokio/rt", "tokio/sync", "futures-util"] | ||
| join-map = ["rt", "hashbrown"] |
There was a problem hiding this comment.
Would this be sufficient?
| join-map = ["rt", "hashbrown"] | |
| join-map = ["tokio/rt", "hashbrown"] |
There was a problem hiding this comment.
Hmm. The mod task requires the rt feature, but ultimately yes it should work with just tokio/rt
|
Looks like just merge conflicts at this point? |
|
Seems I forgot about this. Will check today |
conradludgate
force-pushed
the
conrad/stabalise-joinmap
branch
from
136eb15 to
765fffd
Compare
|
Would the change in #7252 preclude a non breaking change in this API? Can we merge this without 7252 then merge in 7252 as an optimization later? |
Yes, that's my understanding. The only public API change noticeable is removing the |
|
I'd like to get #7257 fixed before we stabilize it. |
Motivation
The other day I saw someone asking for JoinMap to be stabalised. I happened to notice just now that the task ID system is now stable in tokio.
Solution
Removes the unstable config requirement for
tokio_util::JoinMap.