Skip to content

Add missing tests in test_bytes #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

AbeZbm
Copy link

@AbeZbm AbeZbm commented May 15, 2025

Hi,

Thanks for your time to review this PR.

By examing the existing code, we found that some tests can be added to improve the repo's overall test coverage. The tests we submitted have been carefully curated by us to ensure their behavior and effectiveness.
The code region we covered is:

bytes_mut.rs:

bytes/src/bytes_mut.rs

Lines 1180 to 1184 in 141cbc2

if cnt > remaining {
super::panic_advance(&TryGetError {
requested: cnt,
available: remaining,
});

bytes.rs:

"range start must not be greater than end: {:?} <= {:?}",

Thanks again for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant