Optimized quaternion rotation routine #476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like an excellent improvement. I wish it would be merged. My only nit is that adding two floats to implement multiplication by two is probably not worthwhile and possibly slower, since the upshot is a simple increment of the exponent. At any rate, JIT compilation will do the right thing if the code ends up in a critical place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm the author of Quaternion.js and derived a simpler method to rotate a vector using normalized quaternions, reducing the number of multiplications quite a bit. Since gl-matrix is developed with performance in mind, I think this addition can improve quite a few code bases.
All your unit tests are passing. I removed the performance test link, since jsPerf is offline for quite some time now.
Robert