Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shortcut): Use the dialog parent as context #2369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anirvanmandal
Copy link

@anirvanmandal anirvanmandal commented Jan 26, 2025

Please remember the Contributing Guidelines ❤️

🌟 What does this PR do?

  • The toggl popup no longer populate the description for the time entry
  • Use the story dialog parent as the context for the element queries

🐛 Recommendations for testing

All changes should be tested across Chrome and Firefox.

  • Open shortcut.com
  • Open a story card
  • Click the "start time" button in the actions menu
  • Verify that the title of the story and the story id are automatically added as the title of the time entry.

📝 Links to relevant issues or information

- The toggl popup no longer populate the description for the time entry
- Use the story dialog parent as the context for the element queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant