Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

[LibOverhaul 05] Use the prefix increment operator #3340

Merged

Conversation

MartinBriza
Copy link
Contributor

📒 Description

Because of the (perfectly logical) way how C++ works, there's a (very) slight peformance benefit of using the prefix increment operator (++it) compared to the postfix variant (it++) with iterators. cpplint complains about this so I wrote a patch to get rid of the warning.

🕶️ Types of changes

  • New feature (non-breaking change which adds functionality)

🔎 Review hints

  • Same as with most library overhaul PRs, warnings should disappear and the app should continue to compile and work the same on all platforms.

@MartinBriza MartinBriza force-pushed the fix/library-overhaul/rebased/05-uninitialized-members branch from 6f91614 to 92edf7d Compare September 20, 2019 08:14
@NghiaTranUIT NghiaTranUIT self-requested a review October 2, 2019 06:51
Copy link
Contributor

@NghiaTranUIT NghiaTranUIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit for this PR looks good to me 👍

@NghiaTranUIT
Copy link
Contributor

This PR is branched off from https://github.com/toggl/toggldesktop/pull/3338, and this parent has an issues, which need to be address (https://github.com/toggl/toggldesktop/pull/3338#issuecomment-535377952), so I approve and merge it later when it's done.

@MartinBriza MartinBriza force-pushed the fix/library-overhaul/rebased/05-uninitialized-members branch from 92edf7d to 25eaa62 Compare November 26, 2019 13:22
@MartinBriza MartinBriza merged commit 6d5262e into master Nov 27, 2019
@MartinBriza MartinBriza deleted the fix/library-overhaul/rebased/05-uninitialized-members branch November 27, 2019 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants