Open
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 7. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
narasul
approved these changes
Feb 11, 2026
| for e in exc.errors(): | ||
| loc = " -> ".join(str(part) for part in e["loc"]) | ||
| lines.append(f" - {loc}: {e['msg']}") | ||
| return "\n".join(lines) |
Contributor
There was a problem hiding this comment.
More idiomatic way of doing it with pydantic might be just using the @field_validator on every field: https://docs.pydantic.dev/latest/errors/errors/
Contributor
Author
There was a problem hiding this comment.
Feels too extreme to have validators for each field. Also didn't want to fully commit to pydantic yet assuming we might move to msgspec
Contributor
|
seems it broke the tests |
Contributor
Author
Ah Pydantic v1. Will fix |
- ImageConfig.copy → copy_files (shadowed BaseModel.copy in Pydantic v1) - Config._path → config_path, Config._unique_name_tip → unique_name_tip (Pydantic v1 rejects underscore-prefixed fields) - State._config_dir → config_dir, State._project_name → project_name (same reason)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: