Replace TockValue's auto-derived Debug implementation with a hand-written implementation optimized for size. #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This improves the situation described in #84 |
|
The serde version and Debug changes should be independent -- I'll separate the serde changes into separate PRs shortly. |
added 2 commits
August 8, 2019 17:34
…s' toolchain. The latest version of serde requires a newer toolchain. This change allows the examples to keep building, un-breaking the Travil build.
…tten implementation optimized for size. For Google's h1b_tests application, this saves 9440 bytes in .text. The caveat is that invoking Debug on a TockValue will not format the value contained in the TockValue::Expected(). I'm blocking serde updates so that the CI passes.
|
The serde version fix has been separated into #86 . |
jrvanwhy
pushed a commit
to jrvanwhy/tock-on-titan
that referenced
this pull request
Aug 9, 2019
The flash hardware does not accept writes that set bits that were previously unset -- this change emulates that behavior. Depends on tock/libtock-rs#85.
jrvanwhy
pushed a commit
to jrvanwhy/tock-on-titan
that referenced
this pull request
Aug 9, 2019
The flash hardware does not accept writes that set bits that were previously unset -- this change emulates that behavior. Depends on tock/libtock-rs#85.
jrvanwhy
pushed a commit
to jrvanwhy/tock-on-titan
that referenced
this pull request
Aug 9, 2019
The flash hardware does not accept writes that set bits that were previously unset -- this change emulates that behavior. Depends on tock/libtock-rs#85.
jrvanwhy
pushed a commit
to jrvanwhy/tock-on-titan
that referenced
this pull request
Aug 9, 2019
The flash hardware does not accept writes that set bits that were previously unset -- this change emulates that behavior. Depends on tock/libtock-rs#85.
alevy
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Google's h1b_tests application, this saves 9440 bytes in .text. The caveat is that invoking Debug on a TockValue will not format the value contained in the TockValue::Expected().
This contains the commit from #86 so that Travis passes, and should be merged no sooner than #86 .