Skip to content

Switch all crates except tools to use Rust 2021 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Switch all crates except tools to use Rust 2021 #389

merged 1 commit into from
Mar 1, 2022

Conversation

hudson-ayers
Copy link
Contributor

Edition 2021 enables some optimizations such as disjoint closure captures, along with other niceties such as an expanded prelude. This bring libtock-rs in sync with the kernel, which also uses edition 2021.

So far I just tested that make test and make examples build without warnings, and am relying on CI to catch other issues

@jrvanwhy jrvanwhy added the upkeep Indicates a PR is upkeep as defined by the code review policy. label Feb 24, 2022
Copy link
Collaborator

@jrvanwhy jrvanwhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this doesn't switch the workspace to 2021, just the individual crates. E.g. the v1 feature resolver will still be in use.

@hudson-ayers
Copy link
Contributor Author

Note that this doesn't switch the workspace to 2021, just the individual crates. E.g. the v1 feature resolver will still be in use.

My understanding is that specifying an edition for a workspace is ignored (rust-lang/cargo#5784), and that if we want to switch to using the v2 feature resolver we should put resolver="2" in the workspace. I don't have any feelings about what resolver we should be using, however, so I am inclined to leave it as is for now.

@jrvanwhy
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 1, 2022

Build succeeded:

@bors bors bot merged commit e386070 into master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep Indicates a PR is upkeep as defined by the code review policy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants