feat(optimizer)!: annotate compress for mysql - #8018
Conversation
|
One thing I'm unsure about is the implementation: the existing generic type groups don't seem to match the COMPRESS() mapping exactly (for example, TEXT_TYPES includes CHAR, VARCHAR, and TINYTEXT, which have different output types here). Would you prefer that I add new reusable groups in datatypes.py, or should I list the types explicitly in _annotate_compress? |
|
@PiyaDaswadkar let's create |
|
Updated the COMPRESS annotation based on the MySQL type mappings you provided. I added dedicated input type sets in |
|
Done, I updated the implementation to reuse TEXT_TYPES where appropriate and removed the unnecessary single-type set. I also updated the tests accordingly. |
geooo109
left a comment
There was a problem hiding this comment.
@PiyaDaswadkar I will take this PR to the finish line, thanks!
This PR annotate the function Compress for mysql
https://dev.mysql.com/doc/refman/9.7/en/encryption-functions.html#function_compress