fix(optimizer)!: T-SQL Sunday week start, connector grouping and DPipe safe flag in simplify - #8017
Merged
Conversation
…e safe flag in simplify - Set `WEEK_OFFSET = -1` for T-SQL: `DATETRUNC(week, ...)` follows `@@DATEFIRST`, which defaults to 7 (Sunday) - Parenthesize the `NOT NULL` -> `NULL AND TRUE` rewrite when it lands under `NOT` or a different connector, so the generated SQL reparses with the same grouping - Preserve the `safe` flag when `simplify_concat` rebuilds `||` chains, keeping the coercing `CONCAT(CAST(...))` form on transpilation to strict dialects
georgesittas
requested review from
Copilot,
fivetran-kwoodbeck,
geooo109 and
treysp
August 1, 2026 02:17
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing: Overallmain: 192411 total, 153555 passed (pass rate: 79.8%) sqlglot:jo/paren-tsql: 180217 total, 142403 passed (pass rate: 79.0%) Transitions: Dialect pair changes: 0 previous results not found, 3 current results not found ✅ All tests passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WEEK_OFFSET = -1for T-SQL:DATETRUNC(week, ...)follows@@DATEFIRST, which defaults to 7 (Sunday)NOT NULL->NULL AND TRUErewrite when it lands underNOTor a different connector, so the generated SQL reparses with the same groupingsafeflag whensimplify_concatrebuilds||chains, keeping the coercingCONCAT(CAST(...))form on transpilation to strict dialects