support tmux split-pane when restoring processes with ps strategy
#518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normally, `ps.sh` takes the output of `tmux list-panes -F
"#{pane_pid}"` and looks for all the children of that process with a
controlling terminal, because that process is usually a shell. but
if the process in a pane was spawned with `tmux split-pane`, it will
have no parent process other than the tmux server itself.
support this use case by falling back to the active process if the
active process has no children with a controlling terminal.
…erminal look for the default command instead and then filter for its children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normally,
ps.shtakes the output oftmux list-panes -F "#{pane_pid}"and looks for all the children of that process with a controlling terminal, because that process is usually a shell. but if the process in a pane was spawned withtmux split-pane, it will have no parent process other than the tmux server itself.support this use case by falling back to the active process if the active process has no children with a controlling terminal.
fixes #517