feat: Support multiple IPs per hostname in ScanTarget #45
+351
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed ScanTarget to store multiple IP addresses in a List<String> - Updated fromTargetString() to resolve all IPs using getAllByName() - Maintained backward compatibility with deprecated getIp()/setIp() methods - Updated DenylistFileProvider to check all IPs when evaluating denylists - Added MongoDB index for the new ips field - Added comprehensive unit tests for the new functionality Fixes #11
XoMEX
reviewed
Nov 4, 2025
Comment on lines
+168
to
+171
| if (this.ips.isEmpty() || !this.ips.get(0).equals(ip)) { | ||
| this.ips = new ArrayList<>(); | ||
| this.ips.add(ip); | ||
| } |
Member
There was a problem hiding this comment.
I think this could cause weird effects. I would assume that this function just sets ips to a list of size 1.
Comment on lines
+78
to
+83
| for (String ip : target.getIps()) { | ||
| if (ipDenylistSet.contains(ip) | ||
| || cidrDenylist.stream().anyMatch(subnetInfo -> isInSubnet(ip, subnetInfo))) { | ||
| return true; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I'm unsure what the correct behavior is, if a domain resolves to two IPs and only one is denylisted:
1: We do not scan this domain at all. Maybe the domain owner just forgot to tell us all IPs -> the intention of the denylist entry is to not be scanned at all.
2: We scan the domain, but just exclude the denylisted IPs. Maybe the domain is on two different infrastructures, and one of the infrastructures is on our denylist -> domain does not mind being scanned. Also: Some domains may resolve to IPs that are on our denylist for other reasons (local IPs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ScanTargetclass to store multiple IPs in aList<String>fieldfromTargetString()method to resolve all IP addresses usingInetAddress.getAllByName()ipfield and markinggetIp()/setIp()as deprecatedDenylistFileProviderto check all IPs when evaluating denylistsipsfield to support efficient queriesScanTargetandDenylistFileProviderTest Plan
Fixes #11