MySQL 8 support#9
Open
jfhbrook wants to merge 3 commits into
Open
Conversation
Author
|
Not sure what to make of the test failures, but willing to put work in with some direction. |
|
@tk0miya any chances of looking at this PR and releasing a newer version? |
|
@tk0miya any chance you can check on this? I also just bumped into this not working with mysql8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7 . Switches to shrugging when
mysql_install_dbis missing, and usesmysqldto find the base directory. Also updated the syntax in a test, since mysql 8 changed the way that setting passwords works, and handled a deprecation warning in py3.7 while I was in there.Haven't tested against mysql 5.x but did test against my local mysql 8 and seems to be working well!