Skip to content

Conversation

@tjprescott
Copy link
Owner

Closes #72.

This breaking change removes all complexity associated with running the tool with --tsp-compile. It will now require you point --lhs and --rhs at two Swagger specs. This is done with the goal of keeping the core logic tight. Adding TypeSpec compilation functionality added a lot of unnecessary complexity.

@tjprescott tjprescott requested a review from Copilot April 17, 2025 14:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all functionality related to TypeSpec compilation, streamlining the tool to work only with Swagger specs. Key changes include:

  • Removal of TypeSpec-comparison test cases.
  • Deletion of TypeSpec compilation logic from utility and diff client modules.
  • Removal of TypeSpec-related command-line options.

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/rest-api-diff.test.ts Removed test case comparing Swagger and TypeSpec folders.
src/util.ts Removed TypeSpec compilation logic and associated reference handling.
src/parser.ts Left an outdated FIXME comment regarding the rootPath parameter.
src/main.ts Removed TypeSpec-related options from the CLI configuration.
src/diff-client.ts Removed default temporary rhs folder logic formerly used for TypeSpec.
CHANGELOG.md Updated changelog to document the breaking change.
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/parser.ts:43

  • Since TypeSpec functionality has been removed, please update or remove the FIXME comment to avoid confusion about the purpose of the rootPath parameter.
rootPath: string | undefined, // FIXME: This parameter was likely used for TypeSpec

@tjprescott tjprescott marked this pull request as ready for review April 17, 2025 16:03
@tjprescott tjprescott merged commit 767a483 into main Apr 18, 2025
1 check passed
@tjprescott tjprescott deleted the removeTspCompile branch April 18, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove --tsp-compile functionality?

2 participants