Fix inheritance chain expansion #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- package.json: Language not supported
- test/files/inheritanceChain.json: Language not supported
Comments suppressed due to low confidence (2)
test/definition-registry.test.ts:177
- [nitpick] Consider renaming 'expected_properties' to 'expectedProperties' to follow camelCase convention.
let expected_properties = ["aProp", "bProp", "cProp", "dProp"];
src/definitions.ts:456
- Modifying 'derived_set' while iterating over it may lead to infinite loops in cases of circular inheritance chains; consider iterating over a copy of the set or tracking visited elements.
for (const derived of derived_set) {
tjprescott
force-pushed
the
FixInheritanceChain
branch
6 times, most recently
from
2d29d11 to
4192b0f
Compare
tjprescott
force-pushed
the
FixInheritanceChain
branch
from
4192b0f to
99101f1
Compare
tjprescott
added a commit
that referenced
this pull request
Apr 14, 2025
Revert "Merge pull request #79 from tjprescott/FixInheritanceChain"
tjprescott
added a commit
that referenced
this pull request
Apr 14, 2025
Revert "Merge pull request #79 from tjprescott/FixInheritanceChain"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78.