Skip to content

Conversation

@sqmedeiros
Copy link
Contributor

No description provided.

…signLocal. Commented tests related to theses labels
…l to 'parser.lua', following the output of the algorithm
sqmedeiros added 29 commits May 9, 2018 14:58
…hod and key, new alternatives in simpletype)
Copy link
Contributor

@hugomg hugomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking superficially, I noticed that there are some "debug comments" that were committed by accident. I didn't list all of them to avoid being repetitive.

I didn't review the meat of the parser yet. I'll need to learn more about how that works first.

What is the purpose of the annotatedTitan.txt and annotatedTitanMet.txt files? They look like they were generated automatically.

local args = table.pack(...)
if args.n ~= #fields then
error("missing arguments for " .. consname)
error("missing arguments for " .. consname .. tostring(args.n) .. tostring(#fields))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that these were added for debugging but not remover later.
If we want to keep them they should have a space between the numbers at least.

end

lexer.NAME = Cmt(C(possiblename), function(_, pos, s)
--print('lexer', _, pos, s, is_keyword[s])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments should be removed

function defs.number_exp(pos, n)
--print("number_exp", pos, n, math.type(n))
--assert(n ~= 52)
--assert(n ~= '52')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More "debug" comments. Why is 52 important?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants