Fix limits and combinations with other params #424
Merged
+825
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Read header before decoding (effectively unrolls reads) * Fix duplicated error checks * Limited fields now reuse destiantion registers if possible. * Add (generated) tests. Removes output changes from 1.5.0 (tested against larger codebase)
Member
|
This might be simpler implemented as a |
Collaborator
Author
|
@philhofer Yeah. It would also make it possible to "early reject" data that is too big for 32 bit platforms. Since it only affects "new code" with the limit being set I didn't go too hard on the "make it nice" yet. But the reduction in output code would likely be a good thing. |
Collaborator
Author
|
Managed to simplify it a bit, removing some needless extra cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes output changes from 1.5.0 (tested against larger codebase)