Prevent nil pointer exception while reconciling w/ RPC provider

[MrFlynn]

Description

Prevents nil pointer exception when checking length of hmac.secrets for the RPC provider during machine reconciliation. The hmac field in the RPC provider options is an optional field, if it is not defined, it will result in nil pointer exception.

Why is this needed

In provider_opts.go, RPCOptions.HMAC field is marked as optional.

rufio/api/v1alpha1/provider_opts.go

Lines 67 to 69 in 7969e5f

	// HMAC is the options used to create a HMAC signature.
	// +optional
	HMAC *HMACOpts `json:"hmac,omitempty"`

Prior to this change, defining a Machine, Job, or Task using the RPC provider without setting the hmac field would result in a nil pointer exception. A user could bypass this by defining an empty flow map, i.e. hmac: {}. However, since this field is marked as optional, this isn't clear and this change makes the code consistent with the markup in the API definition.

How Has This Been Tested?

This PR includes unit tests to test this particular situation where not HMAC secrets are provided.

How are existing users impacted? What migration steps/scripts do we need?

This PR fixes a bug. Existing users using secrets won't be impacted, and users without secrets will be able to remove a line of yaml from their Rufio-related CRs. No migrations steps are needed.

Checklist:

I have:

• updated the documentation and/or roadmap (if required)
• added unit or e2e tests
• provided instructions on how to upgrade

[jacobweinstock]

Hey @MrFlynn , thanks for the PR. Looks like you have a DCO issue. https://probot.github.io/apps/dco/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.02%. Comparing base (7969e5f) to head (a0365e7).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   46.80%   47.02%   +0.22%     
==========================================
  Files          11       11              
  Lines        1361     1361              
==========================================
+ Hits          637      640       +3     
+ Misses        666      664       -2     
+ Partials       58       57       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[MrFlynn]

@jacobweinstock Weird, I thought I'd done that already. Should be fixed now.

[Copilot]

Pull Request Overview

This PR fixes a bug that could cause a nil pointer exception when the RPC provider's optional HMAC field is not provided. The changes introduce nil checks for HMAC in both machine and task reconciler functions and update corresponding tests to verify behavior when secrets are not provided.

• Updated test cases to simulate RPC reconciliation without HMAC secrets.
• Modified reconciler logic in task.go and machine.go to check for nil HMAC before attempting to retrieve secrets.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
controller/machine_test.go	Updated tests for machine reconciliation to handle missing HMAC.
controller/task_test.go	Updated tests for task reconciliation to handle missing HMAC.
controller/task.go	Added nil check for HMAC in RPC options to avoid nil pointer exception.
controller/machine.go	Added nil check for HMAC in RPC options to avoid nil pointer exception.

Comments suppressed due to low confidence (1)

controller/task_test.go:268

• [nitpick] The variable 'machine' in the createTaskWithRPC function is misleading since the function returns a Task. Consider renaming it to 'task' for clarity.

machine := &v1alpha1.Task{

[jacobweinstock]

Thanks for this, @MrFlynn !