Skip to content

Commit

Permalink
Merge pull request #258 from jacobweinstock/implement-bmclib-update
Browse files Browse the repository at this point in the history
Implement CRD update into bmclib client:

## Description

<!--- Please describe what this PR is going to change -->
The new CRD fields in the redfish provider options were not implemented in the client instantiation.

## Why is this needed

<!--- Link to issue you have raised -->

Fixes: #

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->


## How are existing users impacted? What migration steps/scripts do we need?

<!--- Fixes a bug, unblocks installation, removes a component of the stack etc -->
<!--- Requires a DB migration script, etc. -->


## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
  • Loading branch information
jacobweinstock authored Oct 23, 2024
2 parents adbecd0 + 31610c1 commit 0b6d3cf
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions controller/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ func (b BMCOptions) Translate(host string) []bmclib.Option {
if b.Redfish.Port != 0 {
o = append(o, bmclib.WithRedfishPort(strconv.Itoa(b.Redfish.Port)))
}
if b.Redfish.UseBasicAuth {
o = append(o, bmclib.WithRedfishUseBasicAuth(true))
}
if b.Redfish.SystemName != "" {
o = append(o, bmclib.WithRedfishSystemName(b.Redfish.SystemName))
}
}

// ipmitool options
Expand Down

0 comments on commit 0b6d3cf

Please sign in to comment.