Merge branch 'pu/cw/fixReadOnly' into '2024.11'

tweak(Tinebase): separate hasNotes from hasUserNotes See merge request tine20/tine20!6504
tine-groupware · Feb 7, 2025 · b903a4b · b903a4b
2 parents 06b09f6 + 4ed83aa
commit b903a4b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tine20/Tinebase/js/data/Record.js b/tine20/Tinebase/js/data/Record.js
@@ -402,7 +402,7 @@ Tine.Tinebase.data.Record.create = function(o, meta) {
     f.getDataFields = function() {
         const systemFields = _.map(Tine.Tinebase.Model.genericFields, 'name')
             .concat(f.getMeta('idProperty'))
-            .concat(p.modelConfiguration?.hasNotes ? [] : 'notes')
+            .concat(p.modelConfiguration?.hasUserNotes ? [] : 'notes')
             .concat(p.modelConfiguration?.delegateAclField && p.grantsPath ? String(p.grantsPath).replace(/^data\./, '') : []);
         return _.difference(p.modelConfiguration?.fieldKeys, systemFields);
     };

diff --git a/tine20/Tinebase/js/widgets/grid/PickerGridPanel.js b/tine20/Tinebase/js/widgets/grid/PickerGridPanel.js
@@ -826,7 +826,7 @@ Tine.widgets.grid.PickerGridPanel = Ext.extend(Ext.grid.EditorGridPanel, {
                 openerCt: this,
                 record: JSON.stringify(record.getData()),
                 recordId: record.getId(),
-                fixedFields: this.readOnly ? JSON.stringify(Object.assign(Object.fromEntries(record.constructor.getFieldNames().map((k, i) => [k, null])), record.data)) : null,
+                readOnly: this.readOnly,
                 listeners: {
                     scope: me,
                     update: updateFn