Replaced pin images with inline SVG #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows a far greater number of pins to be able to be shown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a far greater number of pins to be able to be shown, rather than being limited by number of images (~150 previously). Blue pins now appear on the map.
Pins in both the table and the map have been changed.
The SVG is saved inline in the JS, rather than as an external file, so colour and text can be changed within the code. Also a prettier pin can be easily made and used, with the SVG code replacing what is currently there.
Decided to leave getColorString() alone, so there is a hacky if to choose the colour. I wasn't sure where else that was used, and didn't want to break this unwittingly.